]> git.ipfire.org Git - thirdparty/git.git/commit
commit-reach(paint_down_to_common): plug two memory leaks
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 28 Feb 2024 09:44:07 +0000 (09:44 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 28 Feb 2024 17:47:03 +0000 (09:47 -0800)
commite67431d4965d13b185db3ddb4445c3c7034ca62d
tree7848fce72ce93afe70eddfb562753891b2164125
parentf41f85c9ec8d4d46de0fd5fded88db94d3ec8c11
commit-reach(paint_down_to_common): plug two memory leaks

When a commit is missing, we return early (currently pretending that no
merge basis could be found in that case). At that stage, it is possible
that a merge base could have been found already, and added to the
`result`, which is now leaked.

The priority queue has a similar issue: There might still be a commit in
that queue.

Let's release both, to address the potential memory leaks.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
commit-reach.c