]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: seq: Drop UMP events when no UMP-conversion is set
authorTakashi Iwai <tiwai@suse.de>
Mon, 17 Feb 2025 17:00:30 +0000 (18:00 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 17 Feb 2025 17:02:02 +0000 (18:02 +0100)
commite77aa4b2eaa7fb31b2a7a50214ecb946b2a8b0f6
treed597eb2958aff1809a873509e6bea6c6621e8d8b
parent6d1f86610f23b0bc334d6506a186f21a98f51392
ALSA: seq: Drop UMP events when no UMP-conversion is set

When a destination client is a user client in the legacy MIDI mode and
it sets the no-UMP-conversion flag, currently the all UMP events are
still passed as-is.  But this may confuse the user-space, because the
event packet size is different from the legacy mode.

Since we cannot handle UMP events in user clients unless it's running
in the UMP client mode, we should filter out those events instead of
accepting blindly.  This patch addresses it by slightly adjusting the
conditions for UMP event handling at the event delivery time.

Fixes: 329ffe11a014 ("ALSA: seq: Allow suppressing UMP conversions")
Link: https://lore.kernel.org/b77a2cd6-7b59-4eb0-a8db-22d507d3af5f@gmail.com
Link: https://patch.msgid.link/20250217170034.21930-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_clientmgr.c