]> git.ipfire.org Git - thirdparty/qemu.git/commit
esp: restrict non-DMA transfer length to that of available data
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Wed, 13 Sep 2023 20:44:09 +0000 (21:44 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 3 Oct 2023 15:25:13 +0000 (18:25 +0300)
commite855a6ec516b38d60a9a69b2ba4a88d720a97f97
treebf5aee15a21ec40e931a67944318f58a9317cd47
parent8194d5827e6e230136e1ad390298a09d178c0e17
esp: restrict non-DMA transfer length to that of available data

In the case where a SCSI layer transfer is incorrectly terminated, it is
possible for a TI command to cause a SCSI buffer overflow due to the
expected transfer data length being less than the available data in the
FIFO. When this occurs the unsigned async_len variable underflows and
becomes a large offset which writes past the end of the allocated SCSI
buffer.

Restrict the non-DMA transfer length to be the smallest of the expected
transfer length and the available FIFO data to ensure that it is no longer
possible for the SCSI buffer overflow to occur.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1810
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230913204410.65650-3-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 77668e4b9bca03a856c27ba899a2513ddf52bb52)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/scsi/esp.c