]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't cast off_t to 32-bit type for output, bug fix
authorPeter Eisentraut <peter@eisentraut.org>
Wed, 1 Jul 2026 07:39:42 +0000 (09:39 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Wed, 1 Jul 2026 07:39:42 +0000 (09:39 +0200)
commite8f851d61727babe2ce162292b21e6afc89ca65f
treeff6fcacfd437d5a6c50f7b54d78c48a419bae25e
parent8061bfd15abe4d6943ac1563617c19fc069aad70
Don't cast off_t to 32-bit type for output, bug fix

off_t is most likely a 64-bit integer, so casting it to a 32-bit type
for output could lose data.  There are more issues like this in the
tree, but this is an instance where this could actually happen in
practice, since base backups are routinely larger than 4 GB.  So this
is separated out as a bug fix.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org
src/backend/backup/basebackup_server.c