]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
x86/xen/msr: Fix uninitialized variable 'err'
authorXin Li (Intel) <xin@zytor.com>
Sat, 17 May 2025 16:57:12 +0000 (09:57 -0700)
committerIngo Molnar <mingo@kernel.org>
Wed, 21 May 2025 06:44:31 +0000 (08:44 +0200)
commite95534e107d2e9e136aa4d7cbededb3827e80074
tree3b6df10f47e9951ea13cda291f0dcf079694d4ea
parent9220aa8a6779b586ef11bcd5473d103f7cf60756
x86/xen/msr: Fix uninitialized variable 'err'

xen_read_msr_safe() currently passes an uninitialized argument 'err' to
xen_do_read_msr(). But as xen_do_read_msr() may not set the argument,
xen_read_msr_safe() could return err with an unpredictable value.

To ensure correctness, initialize err to 0 (representing success)
in xen_read_msr_safe().

Do the same in xen_read_msr(), even err is not used after being passed
to xen_do_read_msr().

Closes: https://lore.kernel.org/xen-devel/aBxNI_Q0-MhtBSZG@stanley.mountain/
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Link: https://lore.kernel.org/r/20250517165713.935384-1-xin@zytor.com
arch/x86/xen/enlighten_pv.c