]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false
authorThomas Huth <thuth@redhat.com>
Mon, 18 Sep 2017 19:01:25 +0000 (15:01 -0400)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 22 Sep 2017 23:12:35 +0000 (18:12 -0500)
commite96002e0d13cc87910534fd83ca1e6f021dad454
tree36c71d4ab63fbc58a252db84e96239d033098d6f
parentcc7dd3ad3fce9baf0e869847a6ddef33f2b463ab
hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false

QEMU currently aborts with an assertion message when the user is trying
to remove a dscm1xxxx again:

$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
QEMU 2.9.93 monitor - type 'help' for more information
(qemu) device_add dscm1xxxx,id=xyz
(qemu) device_del xyz
**
ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted (core dumped)

Looks like this device has to be wired up in code and is not meant
to be hot-pluggable, so let's mark it with user_creatable = false.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-id: 1503543783-17192-1-git-send-email-thuth@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
(cherry picked from commit 4c93950659487c7ad4f85571ee78524c1e3a94b3)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/ide/microdrive.c