]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: mux-quic: Fix memleak on QUIC stream buffer for unacknowledged data
authorFrédéric Lécaille <flecaille@haproxy.com>
Sat, 20 Aug 2022 16:59:36 +0000 (18:59 +0200)
committerFrédéric Lécaille <flecaille@haproxy.com>
Sat, 20 Aug 2022 17:08:31 +0000 (19:08 +0200)
commitea4a5cbbdfa71cd287d453dffbdf643846754bba
tree100a51eb757e4895a5d8e8b346bb58d6e5924d6c
parentf53201940bc9cc82723b37c924d8c72aa28d3f78
BUG/MINOR: mux-quic: Fix memleak on QUIC stream buffer for unacknowledged data

Some clients send CONNECTION_CLOSE frame without acknowledging the STREAM
data haproxy has sent. In this case, when closing the connection if
there were remaining data in QUIC stream buffers, they were not released.

Add a <closing> boolean option to qc_stream_desc_free() to force the
stream buffer memory releasing upon closing connection.

Thank you to Tristan for having reported such a memory leak issue in GH #1801.

Must be backported to 2.6.
include/haproxy/quic_stream.h
src/quic_stream.c
src/xprt_quic.c