]> git.ipfire.org Git - thirdparty/grub.git/commit
gnulib: Drop fix-base64.patch
authorRobbie Harwood <rharwood@redhat.com>
Tue, 15 Mar 2022 18:05:40 +0000 (14:05 -0400)
committerDaniel Kiper <daniel.kiper@oracle.com>
Mon, 21 Mar 2022 17:50:13 +0000 (18:50 +0100)
commitea780522e17f54b7d5fc5ee17daccedad6f1be93
treec822d256cf91989747279948bdd6b26d656865d3
parent2cd52835fcc291eb2196d9034a25dea08864a214
gnulib: Drop fix-base64.patch

Originally added in commit 9fbdec2f (bootstrap: Add gnulib's base64
module) and subsequently modified in commit 552c9fd08 (gnulib: Fix build
of base64 when compiling with memory debugging), fix-base64.patch
handled two problems we have using gnulib, which are exercised by the
base64 module but not directly caused by it.

First, GRUB defines its own bool type, while gnulib expects the
equivalent of stdbool.h to be present. Rather than patching gnulib,
instead use gnulib's stdbool module to provide a bool type if needed
(suggested by Simon Josefsson).

Second, our config.h doesn't always inherit config-util.h, which is
where gnulib-related options like _GL_ATTRIBUTE_CONST end up.
fix-base64.h worked around this by defining the attribute away, but this
workaround is better placed in config.h itself, not a gnulib patch.

Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
bootstrap.conf
conf/Makefile.extra-dist
config.h.in
grub-core/lib/gnulib-patches/fix-base64.patch [deleted file]
grub-core/lib/posix_wrap/sys/types.h
grub-core/lib/xzembed/xz.h