]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipv4: ip_check_defrag must not modify skb before unsharing
authorJohannes Berg <johannes.berg@intel.com>
Sun, 9 Dec 2012 23:41:06 +0000 (23:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:06:28 +0000 (09:06 -0800)
commiteab34a33cfdda79711f6c66a9f9d7a558238eed8
tree09d4e99697f1c9efc2787c2345fd32ebf01f0fa8
parent6b015f351d9c8a1800f4e234fbfbcc0198bf0b5f
ipv4: ip_check_defrag must not modify skb before unsharing

[ Upstream commit 1bf3751ec90cc3174e01f0d701e8449ce163d113 ]

ip_check_defrag() might be called from af_packet within the
RX path where shared SKBs are used, so it must not modify
the input SKB before it has unshared it for defragmentation.
Use skb_copy_bits() to get the IP header and only pull in
everything later.

The same is true for the other caller in macvlan as it is
called from dev->rx_handler which can also get a shared SKB.

Reported-by: Eric Leblond <eric@regit.org>
Cc: stable@vger.kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_fragment.c