]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Fix race leading to crash when setting up dbus watches
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 18 Dec 2013 12:19:46 +0000 (12:19 +0000)
committerCole Robinson <crobinso@redhat.com>
Thu, 16 Jan 2014 22:30:43 +0000 (17:30 -0500)
commiteafb61dcd9d41571c86c6458204e690427cfe96d
tree3c659e69683598aa9744b1bba2c8ce197a092c33
parent99f8d97aa7498ae06bfbefc0d4d71351d0831016
Fix race leading to crash when setting up dbus watches

Currently the virDBusAddWatch does

  virEventAddHandle(fd, flags,
                    virDBusWatchCallback,
                    watch, NULL);
  dbus_watch_set_data(watch, info, virDBusWatchFree);

Unfortunately this is racy - since the event loop is in a
different thread, the virDBusWatchCallback method may be
run before we get to calling dbus_watch_set_data. We must
reverse the order of these calls

See https://bugzilla.redhat.com/show_bug.cgi?id=885445

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 7d3a1c8bd1a2d376dfb5d7ee6a1bca8772ec2949)
src/util/virdbus.c