]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/riscv/csr.c: fix OVERFLOW_BEFORE_WIDEN in rmw_sctrdepth()
authorDaniel Henrique Barboza <dbarboza@ventanamicro.com>
Fri, 7 Mar 2025 12:46:02 +0000 (09:46 -0300)
committerAlistair Francis <alistair.francis@wdc.com>
Wed, 19 Mar 2025 06:37:24 +0000 (16:37 +1000)
commitec6411a5251de3479d44c6e539d0e9596c68909b
tree7e7a3697f52401476431e0acd525423267aa5f1f
parent3ea8fb521d6161a64879b6f43fac46b4d80d2e39
target/riscv/csr.c: fix OVERFLOW_BEFORE_WIDEN in rmw_sctrdepth()

Coverity found the following issue:

  >>>     CID 1593156:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
  >>>     Potentially overflowing expression "0x10 << depth" with type
  "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and then
  used in a context that expects an expression of type "uint64_t" (64
  bits, unsigned).
  4299             depth = 16 << depth;

Fix it by forcing the expression to be 64 bits wide by using '16ULL'.

Resolves: Coverity CID 1593156
Fixes: c48bd18eae ("target/riscv: Add support for Control Transfer Records extension CSRs.")
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-ID: <20250307124602.1905754-1-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
target/riscv/csr.c