]> git.ipfire.org Git - thirdparty/qemu.git/commit
arm/virt: place power button pin number on a define
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Aug 2024 16:37:56 +0000 (17:37 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 12 Aug 2024 10:40:16 +0000 (11:40 +0100)
commited5031ad5d4c4c3b6eee6ab21aa95ccfc9dffdd4
tree243798d61022a37dc5e576f769f72e555d36fb52
parent446e5e8b4515e9a7be69ef6a29852975289bb6f0
arm/virt: place power button pin number on a define

Having magic numbers inside the code is not a good idea, as it
is error-prone. So, instead, create a macro with the number
definition.

Link: https://lore.kernel.org/qemu-devel/CAFEAcA-PYnZ-32MRX+PgvzhnoAV80zBKMYg61j2f=oHaGfwSsg@mail.gmail.com/
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Message-id: ef0e7f5fca6cd94eda415ecee670c3028c671b74.1723121692.git.mchehab+huawei@kernel.org
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/virt-acpi-build.c
hw/arm/virt.c
include/hw/arm/virt.h