]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
libxfs: shut down filesystem if we xfs_trans_cancel with deferred work items
authorDarrick J. Wong <djwong@kernel.org>
Thu, 6 Jan 2022 22:13:17 +0000 (14:13 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Thu, 20 Jan 2022 00:02:51 +0000 (16:02 -0800)
commited893bc203d73d664401eec504641f6b3f973654
treebec24a675517e8651111e1733bc0459fd315bbc4
parent51e96e1022c06d84843a1f86eed4409954a6fc21
libxfs: shut down filesystem if we xfs_trans_cancel with deferred work items

While debugging some very strange rmap corruption reports in connection
with the online directory repair code.  I root-caused the error to the
following incorrect sequence:

<start repair transaction>
<expand directory, causing a deferred rmap to be queued>
<roll transaction>
<cancel transaction>

Obviously, we should have committed the transaction instead of
cancelling it.  Thinking more broadly, however, xfs_trans_cancel should
have warned us that we were throwing away work item that we already
committed to performing.  This is not correct, and we need to shut down
the filesystem.

Change xfs_trans_cancel to complain in the loudest manner if we're
cancelling any transaction with deferred work items attached.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
libxfs/trans.c