]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions
authorMichael Paquier <michael@paquier.xyz>
Mon, 9 Sep 2024 04:50:02 +0000 (13:50 +0900)
committerMichael Paquier <michael@paquier.xyz>
Mon, 9 Sep 2024 04:50:02 +0000 (13:50 +0900)
commitedb0f6e41b09d261326c5340acad3a2cea59d718
treed6408d708fbdaf2c591ac7ec998b3efe6dbe48de
parentdd20f950d4a37da3e71684f254fcdf4317b752b5
Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions

As introduced by f9900df5f94, a REINDEX CONCURRENTLY job done for an
index with predicates or expressions would set PROC_IN_SAFE_IC in its
MyProc->statusFlags, causing it to be ignored by other concurrent
operations.

Such concurrent index rebuilds should never be ignored, as a predicate
or an expression could call a user-defined function that accesses a
different table than the table where the index is rebuilt.

A test that uses injection points is added, backpatched down to 17.
Michail has proposed a different test, but I have added something
simpler with more coverage.

Oversight in f9900df5f949.

Author: Michail Nikolaev
Discussion: https://postgr.es/m/CANtu0oj9A3kZVduFTG0vrmGnKB+DCHgEpzOp0qAyOgmks84j0w@mail.gmail.com
Backpatch-through: 14
src/backend/commands/indexcmds.c