]> git.ipfire.org Git - thirdparty/dovecot/core.git/commit
lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finish...
authorStephan Bosch <stephan.bosch@dovecot.fi>
Fri, 18 May 2018 08:24:46 +0000 (10:24 +0200)
committerStephan Bosch <stephan.bosch@dovecot.fi>
Fri, 18 May 2018 08:24:46 +0000 (10:24 +0200)
commitede3c3be7fc01e51c62f67071b0c73bf0087b7ad
tree24d7df7e73cba39a5ee79a18ef0784e7f910a65d
parent0963fb105eadfb1814cad6bfc1503204afee1650
lib-smtp: client: Fix assertion panic occurring when DATA dot stream cannot be finished immediately.

If o_stream_finish() returns 0, o_stream_send_istream() would be called again
later which causes the panic. Instead, it should only call o_stream_finish() or
o_stream_flush() again to finish the last bit of the output.

Panic was:

Panic: file ostream.c: line 394 (o_stream_send_istream): assertion failed: (!_outstream->finished)
src/lib-smtp/smtp-client-command.c
src/lib-smtp/smtp-client-private.h