]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: ufs: core: Remove the ufshcd_hba_exit() call from ufshcd_async_scan()
authorBart Van Assche <bvanassche@acm.org>
Mon, 18 Dec 2023 22:52:15 +0000 (14:52 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 4 Jan 2024 04:03:05 +0000 (23:03 -0500)
commitee36710912b2075c417100a8acc642c9c6496501
tree1d42ae662b460d308596961f7a1f616a523b394e
parentdaf7795406bf307997366f694888bd317ae5b5fa
scsi: ufs: core: Remove the ufshcd_hba_exit() call from ufshcd_async_scan()

Calling ufshcd_hba_exit() from a function that is called asynchronously
from ufshcd_init() is wrong because this triggers multiple race
conditions. Instead of calling ufshcd_hba_exit(), log an error message.

Reported-by: Daniel Mentz <danielmentz@google.com>
Fixes: 1d337ec2f35e ("ufs: improve init sequence")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20231218225229.2542156-3-bvanassche@acm.org
Reviewed-by: Can Guo <quic_cang@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c