]> git.ipfire.org Git - thirdparty/qemu.git/commit
tests/data/acpi/virt: drop (most) duplicate files.
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 2 Mar 2023 06:45:28 +0000 (01:45 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 3 Mar 2023 00:13:52 +0000 (19:13 -0500)
commitee92a56b08d0b59016a4a9bc1bf3a3de1fbe3956
treef2eeb17e5a59811624de5c30f5f01d1eaa0bf690
parente16add2b6b888faa2591de035b6cda5f5aef7ae7
tests/data/acpi/virt: drop (most) duplicate files.

When virt ACPI files were added, lots of duplicates were created because
we forgot that there's a no-prefix fallback: e.g. if
tests/data/acpi/virt/APIC.memhp is not there then test will use
tests/data/acpi/virt/APIC.

Drop these.

These were found with
$find tests/data/acpi/ -type f -exec sha256sum '{}' ';'|sort -d|uniq -w 64 --all-repeated=separate
(trick: -d does a dictionary sort so a no-suffix file ends up first).

Note: there are still a bunch of issues with duplicates left even after this.

First pc and q35 are often identical.
Second, sometimes files are identical but not identical to the default
fallback, e.g.
tests/data/acpi/pc/SLIT.cphp and tests/data/acpi/pc/SLIT.memhp
or
tests/data/acpi/q35/HMAT.acpihmat-noinitiator and tests/data/acpi/virt/HMAT.acpihmatvirt

Finding a way to deduplicate these is still a TODO item - softlinks
maybe?

We also need to make rebuild-expected-aml.sh smarter about not creating
these duplicates in the 1st place.

And maybe we should use softlinks instead of relying on a fallback
to make it explicit what version does each test expect?

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
14 files changed:
tests/data/acpi/virt/APIC.memhp [deleted file]
tests/data/acpi/virt/APIC.numamem [deleted file]
tests/data/acpi/virt/DSDT.numamem [deleted file]
tests/data/acpi/virt/FACP.memhp [deleted file]
tests/data/acpi/virt/FACP.numamem [deleted file]
tests/data/acpi/virt/GTDT.memhp [deleted file]
tests/data/acpi/virt/GTDT.numamem [deleted file]
tests/data/acpi/virt/IORT.memhp [deleted file]
tests/data/acpi/virt/IORT.numamem [deleted file]
tests/data/acpi/virt/IORT.pxb [deleted file]
tests/data/acpi/virt/MCFG.memhp [deleted file]
tests/data/acpi/virt/MCFG.numamem [deleted file]
tests/data/acpi/virt/SPCR.memhp [deleted file]
tests/data/acpi/virt/SPCR.numamem [deleted file]