]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdbserver: Fix vAttach response when attaching is not supported
authorPedro Alves <pedro@palves.net>
Fri, 19 Apr 2024 13:37:56 +0000 (14:37 +0100)
committerPedro Alves <pedro@palves.net>
Fri, 26 Apr 2024 20:22:47 +0000 (21:22 +0100)
commitef27d39dd2c2e7b6af70884895e6d751872ae305
tree50c48e1e648a68debcd8971b525ff0b9d8e314b2
parentf1fc8dc2dccb4a224cdd1c3973c7a09a752aa95b
gdbserver: Fix vAttach response when attaching is not supported

handle_v_attach calls attach_inferior, which says:

  "return -1 if attaching is unsupported, 0 if it succeeded, and call
  error() otherwise."

So if attach_inferior return != 0, we have the unsupported case,
meaning we should return the empty packet instead of an error.

In practice, this shouldn't trigger, as vAttach support is supposed to
be reported via qSupported.  But it doesn't hurt to be pedantic here.

Change-Id: I99cce6fa678f2370571e6bca0657451300956127
Approved-By: Tom Tromey <tom@tromey.com>
gdbserver/server.cc