]> git.ipfire.org Git - thirdparty/haproxy.git/commit
projects / thirdparty / haproxy.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f1204b8) | patch
BUG/MEDIUM: tcp-checks: do not dereference inexisting conn_stream
authorWilly Tarreau <w@1wt.eu>
Tue, 23 Jul 2019 12:37:47 +0000 (14:37 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 23 Jul 2019 12:37:47 +0000 (14:37 +0200)
commitef91c939f364367bdc48f1b234c138d743abf56c
tree830a9852aaca5ee1f76f74a9803fa0dfab7fe131tree | snapshot
parentf1204b8933ac5ac777f5dffb9dea6065fd30a03ccommit | diff
BUG/MEDIUM: tcp-checks: do not dereference inexisting conn_stream

Github user @jpulz reported a crash with tcp-checks in issue #184
where cs==NULL. If we enter the function with cs==NULL and check->result
!= CHK_RES_UKNOWN, we'll go directly to out_end_tcpcheck and dereference
cs. We must validate there that cs is valid (and conn at the same time
since it would be NULL as well).

This fix must be backported as far as 1.8.
src/checks.c diff | blob | blame | history
Mirror of https://github.com/haproxy/haproxy.git