]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: pm8001: Remove PM8001_USE_MSIX
authorDamien Le Moal <dlemoal@kernel.org>
Mon, 11 Sep 2023 23:27:43 +0000 (08:27 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 22 Sep 2023 01:39:46 +0000 (21:39 -0400)
commitefa1fca45082c75061a53fa58ca69468f407291c
tree72594efc8744fc631c3ef13677a3149cf5386308
parentd93e1ac40354903812e80733e92566470fa7bd2b
scsi: pm8001: Remove PM8001_USE_MSIX

The pm8001 driver does not compile if PM8001_USE_MSIX is not defined in
pm8001_sas.h because various fields and functions conditionally defined are
used unconditionally without a "#ifdef PM8001_USE_MSIX" protection.  This
macro is rather useless anyway and not convenient as diabling MSI-X use
requires recompiling the driver.

Remove this macro and replace it with the bool module parameter "use_msix"
which defaults to true. The use of MSI-X interrupts for an adapter is gated
by this module parameter for adapters that actually support MSI-X. The
"use_msix" boolean field is added to struct pm8001_hba_info and all code
defined depending on PM8001_USE_MSIX is modified to rely on
pm8001_hba_info->use_msix instead.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20230911232745.325149-9-dlemoal@kernel.org
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_hwi.c
drivers/scsi/pm8001/pm8001_init.c
drivers/scsi/pm8001/pm8001_sas.h
drivers/scsi/pm8001/pm80xx_hwi.c