]> git.ipfire.org Git - people/ms/linux.git/commit
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Thu, 29 Jan 2015 00:23:11 +0000 (16:23 -0800)
committerJiri Slaby <jslaby@suse.cz>
Tue, 10 Feb 2015 10:16:51 +0000 (11:16 +0100)
commitefa4b71b378f2fadd4c99b05da033009b9ec349a
treeff9f56a3da2b8b9b83d6ff10b2ee4ba1971db710
parentd7a5ebfe21c15d1a871587be0006f3fc31e54296
bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify

[ Upstream commit 59ccaaaa49b5b096cdc1f16706a9f931416b2332 ]

Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081

This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
handler does not return any bytes in the skb.

Alternately, the skb->len check can be moved inside rtnl_notify.

For the bridge vlan case described in 92081, there is also a fix needed
in bridge driver to generate a proper notification. Will fix that in
subsequent patch.

v2: rebase patch on net tree

Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/core/rtnetlink.c