]> git.ipfire.org Git - thirdparty/linux.git/commit
ipv6: sr: fix memleak in seg6_hmac_init_algo
authorHangbin Liu <liuhangbin@gmail.com>
Fri, 17 May 2024 00:54:35 +0000 (08:54 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 May 2024 11:16:25 +0000 (13:16 +0200)
commitefb9f4f19f8e37fde43dfecebc80292d179f56c6
tree786dd6ecfd7ff77864aa2b8b6b7e8f17d320f660
parent9841991a446c87f90f66f4b9fee6fe934c1336a2
ipv6: sr: fix memleak in seg6_hmac_init_algo

seg6_hmac_init_algo returns without cleaning up the previous allocations
if one fails, so it's going to leak all that memory and the crypto tfms.

Update seg6_hmac_exit to only free the memory when allocated, so we can
reuse the code directly.

Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support")
Reported-by: Sabrina Dubroca <sd@queasysnail.net>
Closes: https://lore.kernel.org/netdev/Zj3bh-gE7eT6V6aH@hog/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/20240517005435.2600277-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/seg6_hmac.c