]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/pci/pci: Factor out pci_bus_map_irqs() from pci_bus_irqs()
authorBernhard Beschow <shentey@gmail.com>
Mon, 9 Jan 2023 17:23:17 +0000 (18:23 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 13 Jan 2023 15:22:57 +0000 (16:22 +0100)
commitf021f4e9d269746bc89dadf0cac117154733e4be
treec397f92a7840fa8be443b43969d94ef53bd358a1
parent1bdad09bf3326b89add221ef092e57ed81f6e347
hw/pci/pci: Factor out pci_bus_map_irqs() from pci_bus_irqs()

pci_bus_irqs() coupled together the assignment of pci_set_irq_fn and
pci_map_irq_fn to a PCI bus. This coupling gets in the way when the
pci_map_irq_fn is board-specific while the pci_set_irq_fn is device-
specific.

For example, both of QEMU's PIIX south bridge models have different
pci_map_irq_fn implementations which are board-specific rather than
device-specific. These implementations should therefore reside in board
code. The pci_set_irq_fn's, however, should stay in the device models
because they access memory internal to the model.

Factoring out pci_bus_map_irqs() from pci_bus_irqs() allows the
assignments to be decoupled, resolving the problem described above.

Note also how pci_vpb_realize() which gets touched in this commit
assigns different pci_map_irq_fn's depending on the board.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230109172347.1830-5-shentey@gmail.com>
[PMD: Factor out in vfu_object_set_bus_irq()]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/i386/pc_q35.c
hw/isa/piix3.c
hw/isa/piix4.c
hw/pci-host/raven.c
hw/pci-host/versatile.c
hw/pci/pci.c
hw/remote/machine.c
hw/remote/vfio-user-obj.c
include/hw/pci/pci.h