]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pds_fwctl: Remove the use of dev_err_probe()
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 20 Aug 2025 12:40:11 +0000 (20:40 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Fri, 22 Aug 2025 13:14:18 +0000 (10:14 -0300)
commitf12343013022a92fff0cf22cb7b22b9c909cdbf5
tree6a609181f001b6c83d61910e4c2942495d302c0d
parent7f059e47326746ceebe2a984bd6124459df3b458
pds_fwctl: Remove the use of dev_err_probe()

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Link: https://patch.msgid.link/r/20250820124011.474224-1-liaoyuanhong@vivo.com
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/fwctl/pds/main.c