]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: bonding: fix tlb_dynamic_lb default value
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tue, 12 Sep 2017 12:10:05 +0000 (15:10 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Sep 2017 03:58:12 +0000 (20:58 -0700)
commitf13ad104b4e886a03e75f130daf579ef9bf33dfc
tree771aeda1202f2f20486f8cf1ece461f2cf1dd396
parent6c1cb4393cc7e7107e4e94a9a0744451296ca8a6
net: bonding: fix tlb_dynamic_lb default value

Commit 8b426dc54cf4 ("bonding: remove hardcoded value") changed the
default value for tlb_dynamic_lb which lead to either broken ALB mode
(since tlb_dynamic_lb can be changed only in TLB) or setting TLB mode
with tlb_dynamic_lb equal to 0.
The first issue was recently fixed by setting tlb_dynamic_lb to 1 always
when switching to ALB mode, but the default value is still wrong and
we'll enter TLB mode with tlb_dynamic_lb equal to 0 if the mode is
changed via netlink or sysfs. In order to restore the previous behaviour
and default value simply remove the mode check around the default param
initialization for tlb_dynamic_lb which will always set it to 1 as
before.

Fixes: 8b426dc54cf4 ("bonding: remove hardcoded value")
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c