]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:dns_server: use NUMERIC_CMP in rec_cmp()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 4 Apr 2024 01:22:24 +0000 (14:22 +1300)
committerJule Anger <janger@samba.org>
Mon, 10 Jun 2024 13:25:17 +0000 (13:25 +0000)
commitf14a1370f480ad3e37145351746753b489be369d
tree088994c7c00a52d4e2aa5a5592c26707d51b9c8d
parent622bf82fb32796d5d5e80c0cd419ea4adec60b72
s4:dns_server: use NUMERIC_CMP in rec_cmp()

dnsp_DnssrvRpcRecord.dwTimeStamp is uint32_t, making overflow possible.

dnsp_DnssrvRpcRecord.wType is an enum, which has the size of an int,
though it may be hard to set it to overflowing values.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 42ead213484840121ce6bc0db22941ea0a019105)
source4/dns_server/dnsserver_common.c