]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration: Fix madvise breakage if host and guest have different page sizes
authorDavid Gibson <david@gibson.dropbear.id.au>
Tue, 4 Dec 2012 00:38:39 +0000 (11:38 +1100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 14 Jan 2013 21:41:11 +0000 (15:41 -0600)
commitf1a2195ec327fd2b837a3539623ee431d133f03c
tree1d76f2090592f829c113efd18cdd5598a0703b69
parent3b4fc1f9d202d6faade11df9bb6c1dcd61e72b08
migration: Fix madvise breakage if host and guest have different page sizes

madvise(DONTNEED) will throw away the contents of the whole page at the
given address, even if the given length is less than the page size.  One
can argue about whether that's the correct behaviour, but that's what it's
done for a long time in Linux at least.

That means that the madvise() in ram_load(), on a setup where
TARGET_PAGE_SIZE is smaller than the host page size, can throw away data
in guest pages adjacent to the one it's actually processing right now,
leading to guest memory corruption on an incoming migration.

This patch therefore, disables the madvise() if the host page size is
larger than TARGET_PAGE_SIZE.  This means we don't get the benefits of that
madvise() in this case, but a more complete fix is more difficult to
accomplish.  This at least fixes the guest memory corruption.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit 45e6cee42b98d10e2e14885ab656541a9ffd5187)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
arch_init.c