]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pgbench: Fail cleanly when finding a COPY result state
authorMichael Paquier <michael@paquier.xyz>
Fri, 3 Oct 2025 05:04:08 +0000 (14:04 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 3 Oct 2025 05:04:08 +0000 (14:04 +0900)
commitf1a2f3a0c4ea51d9904fd30c9c11cb474312353b
tree39e812f0e6cbb966e2c78e78d0ae257b83efdda9
parentc207bf473ee93d2521921295d814acb56bc71822
pgbench: Fail cleanly when finding a COPY result state

Currently, pgbench aborts when a COPY response is received in
readCommandResponse().  However, as PQgetResult() returns an empty
result when there is no asynchronous result, through getCopyResult(),
the logic done at the end of readCommandResponse() for the error path
leads to an infinite loop.

This commit forcefully exits the COPY state with PQendcopy() before
moving to the error handler when fiding a COPY state, avoiding the
infinite loop.  The COPY protocol is not supported by pgbench anyway, as
an error is assumed in this case, so giving up is better than having the
tool be stuck forever.  pgbench was interruptible in this state.

A TAP test is added to check that an error happens if trying to use
COPY.

Author: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Discussion: https://postgr.es/m/CAO6_XqpHyF2m73ifV5a=5jhXxH2chk=XrgefY+eWWPe2Eft3=A@mail.gmail.com
Backpatch-through: 13
src/bin/pgbench/pgbench.c
src/bin/pgbench/t/001_pgbench_with_server.pl