]> git.ipfire.org Git - thirdparty/qemu.git/commit
pc-bios/s390-ccw: fix sclp_get_loadparm_ascii
authorClaudio Imbrenda <imbrenda@linux.ibm.com>
Thu, 28 Nov 2019 12:33:57 +0000 (13:33 +0100)
committerThomas Huth <thuth@redhat.com>
Fri, 29 Nov 2019 08:16:02 +0000 (09:16 +0100)
commitf24ec9feadfed032a91e06cb3c564db533d5ff11
tree41b11a84548ce64765654a02c6cfffb40bebb11a
parent1a61a081ac33ae6cb7dd2e38d119a572f416c7f7
pc-bios/s390-ccw: fix sclp_get_loadparm_ascii

The existing s390 bios gets the LOADPARM information from the system using
an SCLP call that specifies a buffer length too small to contain all the
output.

The recent fixes in the SCLP code have exposed this bug, since now the
SCLP call will return an error (as per architecture) instead of
writing partially and completing successfully.

The solution is simply to specify the full page length as the SCCB
length instead of a smaller size.

Fixes: 832be0d8a3bb ("s390x: sclp: Report insufficient SCCB length")
Fixes: 9a22473c70f3 ("pc-bios/s390-ccw: get LOADPARM stored in SCP Read Info")
Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Message-Id: <1574944437-31182-1-git-send-email-imbrenda@linux.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Tested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/sclp.c