]> git.ipfire.org Git - people/arne_f/kernel.git/commit
usb: dwc2: gadget: Fix GOUTNAK flow for Slave mode.
authorMinas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Tue, 13 Jul 2021 05:32:55 +0000 (09:32 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jul 2021 12:35:44 +0000 (14:35 +0200)
commitf2c04f6b21ef94c67202a2a2e257c5e35a7bc375
tree1e19fc80168c47afab98744ce553f56b3a91bb6f
parent7073acb51a3b4c8d74bf317cd6a860f57fac659b
usb: dwc2: gadget: Fix GOUTNAK flow for Slave mode.

commit fecb3a171db425e5068b27231f8efe154bf72637 upstream.

Because of dwc2_hsotg_ep_stop_xfr() function uses poll
mode, first need to mask GINTSTS_GOUTNAKEFF interrupt.
In Slave mode GINTSTS_GOUTNAKEFF interrupt will be
aserted only after pop OUT NAK status packet from RxFIFO.

In dwc2_hsotg_ep_sethalt() function before setting
DCTL_SGOUTNAK need to unmask GOUTNAKEFF interrupt.

Tested by USBCV CH9 and MSC tests set in Slave, BDMA and DDMA.
All tests are passed.

Fixes: a4f827714539a ("usb: dwc2: gadget: Disable enabled HW endpoint in dwc2_hsotg_ep_disable")
Fixes: 6070636c4918c ("usb: dwc2: Fix Stalling a Non-Isochronous OUT EP")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Link: https://lore.kernel.org/r/e17fad802bbcaf879e1ed6745030993abb93baf8.1626152924.git.Minas.Harutyunyan@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc2/gadget.c