]> git.ipfire.org Git - thirdparty/gcc.git/commit
Align a 'OMP_TARGET_OFFLOAD=mandatory' diagnostic with others
authorThomas Schwinge <thomas@codesourcery.com>
Wed, 14 Jun 2023 10:44:05 +0000 (12:44 +0200)
committerThomas Schwinge <thomas@codesourcery.com>
Wed, 14 Jun 2023 10:56:35 +0000 (12:56 +0200)
commitf2ef1dabbc18eb6efc0eb47bbb0eebbc6d72e09e
tree7214bffaf053bffd501180c36ccd42cf36909cf9
parent4bcb46b3ade1796c5a57b294f5cca25f00671cac
Align a 'OMP_TARGET_OFFLOAD=mandatory' diagnostic with others

On 2023-06-14T11:42:22+0200, Tobias Burnus <tobias@codesourcery.com> wrote:
> On 14.06.23 10:09, Thomas Schwinge wrote:
>> Let me know if I should also adjust the new 'target { ! offload_device }'
>> diagnostic "[...] MANDATORY but only the host device is available" to
>> include a comma before 'but', for consistency with the other existing
>> diagnostics (cited above)?
>
> I think it makes sense to be consistent. Thus: Yes, please add the commas.

Fix-up for recent commit 18c8b56c7d67a9e37acf28822587786f0fc0efbc
"OpenMP: Set default-device-var with OMP_TARGET_OFFLOAD=mandatory".

libgomp/
* target.c (resolve_device): Align a
'OMP_TARGET_OFFLOAD=mandatory' diagnostic with others.
* testsuite/libgomp.c/target-51.c: Adjust.
libgomp/target.c
libgomp/testsuite/libgomp.c/target-51.c