]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga-win: include glib when building VSS DLL
authorMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 12 Feb 2019 21:29:16 +0000 (15:29 -0600)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 28 Mar 2019 16:26:43 +0000 (11:26 -0500)
commitf3a70a4ae16ab118b5eab137644cb76181fbec18
treece177b1938cd9d62ee3846ebfe32f67930a4184b
parentd7cae05bf555032c2e8941aaf581fbd97fae8fed
qga-win: include glib when building VSS DLL

Commit 3ebee3b191e defined assert() as g_assert(), but when we build
the VSS DLL component of QGA (to handle fsfreeze) we do not include
glib, which results in breakage when building with VSS support enabled.

Fix this by including glib (along with the -lintl and -lws2_32
dependencies it brings).

Since the VSS DLL is built statically, this introduces an additional
dependency on static glib and supporting libs for the mingw environment
(possibly why we didn't include glib originally), but VSS support
already has very specific prerequisites so it shouldn't affect too many
build environments.

Since the VSS DLL code does use qemu/osdep.h, this should also help
avoid future breakages and possibly allow for some clean ups in current
VSS code.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
(cherry picked from commit 82a58d270c6fbbe2f2381224946340fd3814a273)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/vss-win32/Makefile.objs