]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KVM: PPC: Book3S HV: radix: Fix uninitialized var build error
authorMichael Ellerman <mpe@ellerman.id.au>
Sun, 30 Dec 2018 03:05:13 +0000 (14:05 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sun, 30 Dec 2018 03:05:13 +0000 (14:05 +1100)
commitf460772291f8171988b2b60141a45706123d0c69
tree2f6ec8ee9738ffa2a741b93c02ef759fadd19a26
parent42aee37298f4b1d91ecb55530a62de249ecf4266
KVM: PPC: Book3S HV: radix: Fix uninitialized var build error

Old GCCs (4.6.3 at least), aren't able to follow the logic in
__kvmhv_copy_tofrom_guest_radix() and warn that old_pid is used
uninitialized:

  arch/powerpc/kvm/book3s_64_mmu_radix.c:75:3: error: 'old_pid' may be
  used uninitialized in this function

The logic is OK, we only use old_pid if quadrant == 1, and in that
case it has definitely be initialised, eg:

if (quadrant == 1) {
old_pid = mfspr(SPRN_PID);
...
if (quadrant == 1 && pid != old_pid)
mtspr(SPRN_PID, old_pid);

Annotate it to fix the error.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kvm/book3s_64_mmu_radix.c