]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 15 Oct 2013 14:47:16 +0000 (16:47 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 21 Feb 2014 03:36:14 +0000 (21:36 -0600)
commitf47542925e334e17204371df2a1c9a50fa4157af
tree0b348cdc3ba4f1bbef7054aa48b201e9e188370d
parent0e7b9f06a6cc032be6ca2ac55a27592abd374179
virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

Similar to the PCI bug that prompted these patches, virtio-ccw will
segfault after the reworking of hotplug/hot-unplug.  Prepare for
this by moving virtio_ccw_stop_ioeventfd to before the freeing
of the proxy device.

A better place for this could be the device_unplugged callback
for the virtio-ccw bus.  However, we do not yet have a callback
that works: this patch avoids the problem while leaving the tree
bisectable.

Cc: qemu-stable@nongnu.org
Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Suggested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 0b81c1ef5c677c2a07be5f8bf0dfe2c62ef52115)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/s390x/virtio-ccw.c