]> git.ipfire.org Git - thirdparty/bootstrap.git/commit
v4: Disabled link cleanup (#34924)
authorPatrick H. Lauke <redux@splintered.co.uk>
Thu, 9 Sep 2021 11:49:06 +0000 (12:49 +0100)
committerGitHub <noreply@github.com>
Thu, 9 Sep 2021 11:49:06 +0000 (14:49 +0300)
commitf4a1a35cf245566018b109af7b56d69cd6f13975
tree73562082588f273ec1e28d6131176f909fb1af10
parent408252eff147c1f48a45db1ea47697c89dd9dace
v4: Disabled link cleanup (#34924)

manual backport of #34886

per https://www.w3.org/TR/html-aria/#docconformance

> It is NOT RECOMMENDED to use `aria-disabled="true"` on an `a` element with an `href` attribute.
>
>NOTE
>If a link needs to be "disabled", remove the `href` attribute.

This PR removes the unnecessary `href="#"`, `tabindex="-1"`, and `aria-disabled="true"` from disabled links in both docs pages and examples. `aria-disabled="true"` *is* kept for disabled link-based buttons (that have `role="button"`) as there it's appropriate to use (you *want* to convey to assistive technologies that this thing you're claiming is a button is also disabled at the moment)

Further, the PR extends the "Link functionality caveat" to show the "proper" way (removing `href` and adding `.disabled` class only) to disable a link, but then explains what to do if that's not possible (and then keeps an example with all the traditional `href="#" tabindex="-1" aria-disabled="true"`, but explains clearly that it's not ideal). Same sort of explanation is also added to the pointer event utilities page
16 files changed:
site/content/docs/4.6/components/buttons.md
site/content/docs/4.6/components/card.md
site/content/docs/4.6/components/dropdowns.md
site/content/docs/4.6/components/list-group.md
site/content/docs/4.6/components/navbar.md
site/content/docs/4.6/components/navs.md
site/content/docs/4.6/components/pagination.md
site/content/docs/4.6/examples/blog/index.html
site/content/docs/4.6/examples/carousel/index.html
site/content/docs/4.6/examples/jumbotron/index.html
site/content/docs/4.6/examples/navbar-bottom/index.html
site/content/docs/4.6/examples/navbar-fixed/index.html
site/content/docs/4.6/examples/navbar-static/index.html
site/content/docs/4.6/examples/navbars/index.html
site/content/docs/4.6/examples/starter-template/index.html
site/content/docs/4.6/examples/sticky-footer-navbar/index.html