]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: chacha20poly1305 - prevent integer overflow on large input
authorJason A. Donenfeld <Jason@zx2c4.com>
Thu, 6 Feb 2020 11:42:01 +0000 (12:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 16:23:40 +0000 (17:23 +0100)
commitf5122114c190615f10b1889918c34f94667c5b88
treee113cbc4c7c815d5973da7e074e3fa4a9459c001
parent7cad6ccee697b8f425ecd2c9222784c7c16561ca
crypto: chacha20poly1305 - prevent integer overflow on large input

commit c9cc0517bba9f0213f1e55172feceb99e5512daf upstream.

This code assigns src_len (size_t) to sl (int), which causes problems
when src_len is very large. Probably nobody in the kernel should be
passing this much data to chacha20poly1305 all in one go anyway, so I
don't think we need to change the algorithm or introduce larger types
or anything. But we should at least error out early in this case and
print a warning so that we get reports if this does happen and can look
into why anybody is possibly passing it that much data or if they're
accidently passing -1 or similar.

Fixes: d95312a3ccc0 ("crypto: lib/chacha20poly1305 - reimplement crypt_from_sg() routine")
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: stable@vger.kernel.org # 5.5+
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/crypto/chacha20poly1305.c