]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
perf/core: Fix broken throttling when max_samples_per_tick=1
authorQing Wang <wangqing7171@gmail.com>
Sat, 5 Apr 2025 14:16:35 +0000 (22:16 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Fri, 25 Apr 2025 12:55:22 +0000 (14:55 +0200)
commitf51972e6f8b9a737b2b3eb588069acb538fa72de
treea353ecc13afd9a969b16cc77eee76d0da825551b
parent1caafd919e2a5c483f7a27449f8497fa4b15a44f
perf/core: Fix broken throttling when max_samples_per_tick=1

According to the throttling mechanism, the pmu interrupts number can not
exceed the max_samples_per_tick in one tick. But this mechanism is
ineffective when max_samples_per_tick=1, because the throttling check is
skipped during the first interrupt and only performed when the second
interrupt arrives.

Perhaps this bug may cause little influence in one tick, but if in a
larger time scale, the problem can not be underestimated.

When max_samples_per_tick = 1:
Allowed-interrupts-per-second max-samples-per-second  default-HZ  ARCH
200                           100                     100         X86
500                           250                     250         ARM64
...
Obviously, the pmu interrupt number far exceed the user's expect.

Fixes: e050e3f0a71b ("perf: Fix broken interrupt rate throttling")
Signed-off-by: Qing Wang <wangqing7171@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250405141635.243786-3-wangqing7171@gmail.com
kernel/events/core.c