]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ide/atapi: Be explicit that assigning to s->lcyl truncates
authorPeter Maydell <peter.maydell@linaro.org>
Wed, 31 Jul 2024 14:36:14 +0000 (15:36 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 6 Aug 2024 08:22:52 +0000 (10:22 +0200)
commitf63085c85d164484a58fa320114f389c91194487
treefdbf36166454e4640c828632de9caa83b7dc0a58
parent8f64e7449e474e18017eb1414bc13e491edd8596
hw/ide/atapi: Be explicit that assigning to s->lcyl truncates

In ide_atapi_cmd_reply_end() we calculate a 16-bit size, and then
assign its two halves to s->lcyl and s->hcyl like this:

           s->lcyl = size;
           s->hcyl = size >> 8;

Coverity warns that the first line here can overflow the
8-bit s->lcyl variable. This is true, and in this case we're
deliberately only after the low 8 bits of the value. The
code is clearer to both humans and Coverity if we're explicit
that we only wanted the low 8 bits, though.

Resolves: Coverity CID 1547621
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20240731143617.3391947-5-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/ide/atapi.c