]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "usb: gadget: u_serial: Add null pointer check in gs_start_io"
authorKuen-Han Tsai <khtsai@google.com>
Tue, 17 Jun 2025 05:07:11 +0000 (13:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2025 10:41:09 +0000 (12:41 +0200)
commitf6c7bc4a6823a0a959f40866a1efe99bd03c2c5b
tree4d2dc839dd90be3d2d8f5e690e3d4a4693e91363
parent31a6afbe86e8e9deba9ab53876ec49eafc7fd901
Revert "usb: gadget: u_serial: Add null pointer check in gs_start_io"

This reverts commit ffd603f214237e250271162a5b325c6199a65382.

Commit ffd603f21423 ("usb: gadget: u_serial: Add null pointer check in
gs_start_io") adds null pointer checks at the beginning of the
gs_start_io() function to prevent a null pointer dereference. However,
these checks are redundant because the function's comment already
requires callers to hold the port_lock and ensure port.tty and port_usb
are not null. All existing callers already follow these rules.

The true cause of the null pointer dereference is a race condition. When
gs_start_io() calls either gs_start_rx() or gs_start_tx(), the port_lock
is temporarily released for usb_ep_queue(). This allows port.tty and
port_usb to be cleared.

Fixes: ffd603f21423 ("usb: gadget: u_serial: Add null pointer check in gs_start_io")
Cc: stable <stable@kernel.org>
Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
Reviewed-by: Prashanth K <prashanth.k@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250617050844.1848232-1-khtsai@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/u_serial.c