]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix deadlock at startup, if max_prepared_transactions is too small.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2015 18:25:44 +0000 (21:25 +0300)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Thu, 23 Apr 2015 18:36:24 +0000 (21:36 +0300)
commitf73ebd766a4903ab937b28c3cc90a53b6dcb61f4
tree772bc4bb00e790f47490e1f24197f326a12a261e
parent7954bc5ecb888a5e2f374871685c8a43546c328d
Fix deadlock at startup, if max_prepared_transactions is too small.

When the startup process recovers transactions by scanning pg_twophase
directory, it should clear MyLockedGxact after it's done processing each
transaction. Like we do during normal operation, at PREPARE TRANSACTION.
Otherwise, if the startup process exits due to an error, it will try to
clear the locking_backend field of the last recovered transaction. That's
usually harmless, but if the error happens in MarkAsPreparing, while
holding TwoPhaseStateLock, the shmem-exit hook will try to acquire
TwoPhaseStateLock again, and deadlock with itself.

This fixes bug #13128 reported by Grant McAlister. The bug was introduced
by commit bb38fb0d, so backpatch to all supported versions like that
commit.
src/backend/access/transam/twophase.c