]> git.ipfire.org Git - thirdparty/openssl.git/commit
CRYPTO_mem_debug_push() and CRYPTO_mem_debug_pop() should return 0
authorMatt Caswell <matt@openssl.org>
Tue, 9 Aug 2022 10:59:22 +0000 (11:59 +0100)
committerTomas Mraz <tomas@openssl.org>
Wed, 17 Aug 2022 10:57:48 +0000 (12:57 +0200)
commitf868454257560c78570549f6a34d5918f03898a0
tree8763e1e49c597c6e9c4b2b6404bf82ee2d360e2c
parent2c35d61790603530d11f52eda9132ff8640f9852
CRYPTO_mem_debug_push() and CRYPTO_mem_debug_pop() should return 0

Those 2 functions historically only ever returned 0 or 1. In OpenSSL 3.0
they were made no-ops and the documentation says they always return 0. In
fact they were returning -1. If any application was actually using these
functions then it may appear that they were actually successful (e.g. -1
could be interpreted as "true").

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18967)
crypto/mem.c