]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect/address: remove useless checks
authorVictor Julien <vjulien@oisf.net>
Tue, 26 Apr 2022 18:04:28 +0000 (20:04 +0200)
committerVictor Julien <vjulien@oisf.net>
Wed, 27 Apr 2022 10:17:51 +0000 (12:17 +0200)
commitf8a0f3d9b9f4e1aa758a493e00d38e98a552a0d6
tree00074e0d0d8a81f19b5d6108967ec8381d6fda2d
parentbad900516133a81afb0a6d3982fa3de5871e6ba7
detect/address: remove useless checks

Cppcheck flagged this:

src/detect-engine-address.c:1035:48: warning: Either the condition 'ghn!=NULL' is redundant or there is possible null pointer dereference: gh. [nullPointerRedundantCheck]
    int r = DetectAddressIsCompleteIPSpaceIPv4(gh->ipv4_head);
                                               ^
src/detect-engine-address.c:1297:17: note: Assuming that condition 'ghn!=NULL' is not redundant
        if (ghn != NULL) {
                ^
src/detect-engine-address.c:1283:44: note: Calling function 'DetectAddressIsCompleteIPSpace', 1st argument 'ghn' value is 0
        if (DetectAddressIsCompleteIPSpace(ghn)) {
                                           ^
src/detect-engine-address.c:1035:48: note: Null pointer dereference
    int r = DetectAddressIsCompleteIPSpaceIPv4(gh->ipv4_head);
                                               ^

Cleanup code could only be reached with non-NULL pointers, so simplify checks.

Bug: #5291.
src/detect-engine-address.c