]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: xilinx_can: xcan_probe(): check for error irq
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Fri, 24 Dec 2021 02:13:24 +0000 (10:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:21 +0000 (09:04 +0100)
commitf8c40011f0ec48fad40477e6ee1c790a235ea07b
tree2b821a014afe8d8dfcfe063c51d4550b74f9e88e
parent447b650f9c22ee7c94a0045db23bf62eb81ef2d9
can: xilinx_can: xcan_probe(): check for error irq

[ Upstream commit c6564c13dae25cd7f8e1de5127b4da4500ee5844 ]

For the possible failure of the platform_get_irq(), the returned irq
could be error number and will finally cause the failure of the
request_irq().

Consider that platform_get_irq() can now in certain cases return
-EPROBE_DEFER, and the consequences of letting request_irq()
effectively convert that into -EINVAL, even at probe time rather than
later on. So it might be better to check just now.

Fixes: b1201e44f50b ("can: xilinx CAN controller support")
Link: https://lore.kernel.org/all/20211224021324.1447494-1-jiasheng@iscas.ac.cn
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/xilinx_can.c