]> git.ipfire.org Git - thirdparty/qemu.git/commit
ui: compile dbus-display1.c with -fPIC as necessary
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Tue, 19 Mar 2024 09:25:02 +0000 (13:25 +0400)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 21 Mar 2024 17:13:44 +0000 (20:13 +0300)
commitf8fb5928a850f889bbb949486149a5de3da8295b
tree9269cd80d8f7b6f6fe2e45d15282877daf57cde1
parentde742b16b3253bb9a194d623d0b751844bed8bc7
ui: compile dbus-display1.c with -fPIC as necessary

Building dbus-display1.c explicitly as a static library drops -fPIC by
default, which may not be correct if it ends up linked to a shared
library.

Let the target decide how to build the unit, with or without -fPIC. This
makes commit 186acfbaf7 ("tests/qtest: Depend on dbus_display1_dep") no
longer relevant, as dbus-display1.c will be recompiled.

Fixes: c172136ea33 ("meson: ensure dbus-display generated code is built
before other units")

Reported-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
(cherry picked from commit d4069a84a3380247c1b524096c6a807743bf687a)
ui/meson.build