]> git.ipfire.org Git - thirdparty/gcc.git/commit
c++/modules: anon union member of as-base class [PR112580]
authorPatrick Palka <ppalka@redhat.com>
Fri, 9 Feb 2024 17:40:28 +0000 (12:40 -0500)
committerPatrick Palka <ppalka@redhat.com>
Fri, 9 Feb 2024 17:40:28 +0000 (12:40 -0500)
commitf931bd7725f5cea948dd55ac370b5b9fd9a00198
tree0d530ed3a48e613f6794d562198096339558513f
parentc9bdcb0c3433ce09f5bb713a51a14130858578a2
c++/modules: anon union member of as-base class [PR112580]

Here when streaming in the fields of the as-base version of
_Formatting_scanner<int> we end up overwriting ANON_AGGR_TYPE_FIELD
of the anonymous union type, since it turns out this type is shared
between the original FIELD_DECL and the as-base FIELD_DECL copy (copied
during layout_class_type).  ANON_AGGR_TYPE_FIELD first gets properly set
to the original FIELD_DECL when streaming in the canonical definition of
_Formatting_scanner<int>, and then gets overwritten to the as-base
FIELD_DECL when streaming in the the as-base definition.  This leads to
lookup_anon_field later giving the wrong answer when resolving the
_M_values use at instantiation time.

This patch makes us avoid overwriting ANON_AGGR_TYPE_FIELD when streaming
in an as-base class definition; it should already be properly set at that
point.

PR c++/112580

gcc/cp/ChangeLog:

* module.cc (trees_in::read_class_def): When streaming in
an anonymous union field of an as-base class, don't overwrite
ANON_AGGR_TYPE_FIELD.

gcc/testsuite/ChangeLog:

* g++.dg/modules/anon-3_a.H: New test.
* g++.dg/modules/anon-3_b.C: New test.

Reviewed-by: Jason Merrill <jason@redhat.com>
gcc/cp/module.cc
gcc/testsuite/g++.dg/modules/anon-3_a.H [new file with mode: 0644]
gcc/testsuite/g++.dg/modules/anon-3_b.C [new file with mode: 0644]