]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Clean up tls_authentication_status and document it
authorArne Schwabe <arne@rfc2549.org>
Fri, 23 Oct 2020 12:02:56 +0000 (14:02 +0200)
committerGert Doering <gert@greenie.muc.de>
Wed, 25 Nov 2020 17:38:39 +0000 (18:38 +0100)
commitf9d3fbf9bc87ae6c05fc592712f610491a77d78b
treef59cbbc73ff32263863db27accf6e99fffe6d342
parentf1f0f074bf6e7b91673bfa8cb08b3be44ebda76b
Clean up tls_authentication_status and document it

The gain of the used optimisation approach of using a array with a
calculated index in favour of simple ifs is questionable with modern
compilers and the readability of the function suffers.

Also change the return type from simple int to an enum and add comments
and doxygen documentation.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20201023120259.29783-4-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21224.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/push.c
src/openvpn/ssl.c
src/openvpn/ssl_verify.c
src/openvpn/ssl_verify.h