]> git.ipfire.org Git - thirdparty/libvirt.git/commit
util: ensure safe{read,write,zero} return is checked
authorEric Blake <eblake@redhat.com>
Tue, 2 Mar 2010 16:35:01 +0000 (09:35 -0700)
committerEric Blake <eblake@redhat.com>
Thu, 15 Apr 2010 17:40:08 +0000 (11:40 -0600)
commitf9f6c34c5ca8446d4b90b02525524dac35d05b46
tree2c7cef507ad0a736f40313664db2773f63174851
parentcf4dee3615c7b6f6d49e59baa93c3a0db2c71010
util: ensure safe{read,write,zero} return is checked

Based on a warning from coverity.  The safe* functions
guarantee complete transactions on success, but don't guarantee
freedom from failure.

* src/util/util.h (saferead, safewrite, safezero): Add
ATTRIBUTE_RETURN_CHECK.
* src/remote/remote_driver.c (remoteIO, remoteIOEventLoop): Ignore
some failures.
(remoteIOReadBuffer): Adjust error messages on read failure.
* daemon/event.c (virEventHandleWakeup): Ignore read failure.
daemon/event.c
src/remote/remote_driver.c
src/util/util.h