]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
HID: multitouch: handle faulty Elo touch device
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tue, 21 May 2019 13:38:31 +0000 (15:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jun 2019 06:17:58 +0000 (08:17 +0200)
commitfa212dd5a6040c601924657fdbdb32cf700a0b62
treea8d68ea058c61d7fc58590e0b66aaff4cbd00538
parent9ae306d8dbc874de331bb10a4451a5198b660257
HID: multitouch: handle faulty Elo touch device

commit 81bcbad53bab4bf9f200eda303d7a05cdb9bd73b upstream.

Since kernel v5.0, one single win8 touchscreen device failed.
And it turns out this is because it reports 2 InRange usage per touch.

It's a first, and I *really* wonder how this was allowed by Microsoft in
the first place. But IIRC, Breno told me this happened *after* a firmware
upgrade...

Anyway, better be safe for those crappy devices, and make sure we have
a full slot before jumping to the next.
This won't prevent all crappy devices to fail here, but at least we will
have a safeguard as long as the contact ID and the X and Y coordinates
are placed in the report after the grabage.

Fixes: 01eaac7e5713 ("HID: multitouch: remove one copy of values")
CC: stable@vger.kernel.org # v5.0+
Reported-and-tested-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-multitouch.c