]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
dpll: zl3073x: fix memory leak on pin registration failure
authorIvan Vecera <ivecera@redhat.com>
Tue, 19 May 2026 13:22:05 +0000 (15:22 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 May 2026 02:02:01 +0000 (19:02 -0700)
commitfa997ddef508b1b37b2fe4d2dad7c4b70958335e
treebb4df998853cc1f44a422d7f4f145400cb3c1620
parente4bdef4d320b2fe73b8ebfc0cc0507fa9dc4a3b7
dpll: zl3073x: fix memory leak on pin registration failure

If zl3073x_dpll_pin_register() fails, the allocated pin is not yet
added to zldpll->pins list. The error path calls
zl3073x_dpll_pins_unregister() which only iterates pins on the list,
so the current pin is leaked. Free the pin before jumping to the error
label.

Additionally move the pin->dpll_pin = NULL assignment in
zl3073x_dpll_pin_register() from err_register to the common
err_pin_get path. When dpll_pin_get() fails, pin->dpll_pin holds an
ERR_PTR value. Without this fix the subsequent zl3073x_dpll_pin_free()
would trigger a spurious WARN because it checks pin->dpll_pin for
non-NULL.

Fixes: 75a71ecc2412 ("dpll: zl3073x: Register DPLL devices and pins")
Reviewed-by: Petr Oros <poros@redhat.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Link: https://patch.msgid.link/20260519132205.161847-1-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/dpll/zl3073x/dpll.c