]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm: writeback: Fix drm_writeback_connector_cleanup signature
authorLouis Chauvet <louis.chauvet@bootlin.com>
Tue, 29 Apr 2025 08:36:23 +0000 (10:36 +0200)
committerLouis Chauvet <louis.chauvet@bootlin.com>
Mon, 23 Jun 2025 08:12:44 +0000 (10:12 +0200)
commitfb721b2c35b1829b8ecf62e3adb41cf30260316a
tree8836022f96ef0362d227d97a0052da26bcc5b4bc
parent61ee19dedb8d753249e20308782bf4e9e2fb7344
drm: writeback: Fix drm_writeback_connector_cleanup signature

The drm_writeback_connector_cleanup have the signature:

     static void drm_writeback_connector_cleanup(
struct drm_device *dev,
struct drm_writeback_connector *wb_connector)

But it is stored and used as a drmres_release_t

    typedef void (*drmres_release_t)(struct drm_device *dev, void *res);

While the current code is valid and does not produce any warning, the
CFI runtime check (CONFIG_CFI_CLANG) can fail because the function
signature is not the same as drmres_release_t.

In order to fix this, change the function signature to match what is
expected by drmres_release_t.

Fixes: 1914ba2b91ea ("drm: writeback: Create drmm variants for drm_writeback_connector initialization")
Suggested-by: Mark Yacoub <markyacoub@google.com>
Reviewed-by: MaĆ­ra Canal <mcanal@igalia.com>
Link: https://lore.kernel.org/r/20250429-drm-fix-writeback-cleanup-v2-1-548ff3a4e284@bootlin.com
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
drivers/gpu/drm/drm_writeback.c